search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

proto: bump to 1.6.x 2f6f381 #354

Closed chhsia0 closed 6 years ago

chhsia0 commented 6 years ago

Updated Mesos protos to 1.6.x, which adds a new master call for GET_OPERATIONS, and new agent calls for GET_OPERATIONS, GROW_VOLUME and SHRINK_VOLUME. For the latter two, only agent-local volumes are supported.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 58.153% when pulling 381eadef8c21cdb35f38654488d0c12e1eeabb7a on chhsia0:bump-1.6.x-2f6f381 into 29de6ff97b48c29cb5ac07029ed75186e5ba0eed on mesos:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 57.363% when pulling c11ae24a42928ba539d45f8b793d7483227c7397 on chhsia0:bump-1.6.x-2f6f381 into 2928a8dad66db875eae3f8b0d9d387ae41934832 on mesos:master.

jdef commented 6 years ago

Thanks, left some feedback. Surprised that schedulerpb_test.go didn't have any changes

jdef commented 6 years ago

I'm fine w/ GrowVolume/ShrinkVolume

On Thu, Jul 19, 2018 at 1:56 PM Chun-Hung Hsiao notifications@github.com wrote:

@chhsia0 commented on this pull request.

In api/v1/lib/master/calls/calls.go https://github.com/mesos/mesos-go/pull/354#discussion_r203818174:

+// GrowLocalVolume grows a persistent volume on an agent's ROOT or PATH disks. The request is forwarded asynchronously +// to the Mesos agent where the persistent volume is located. +func GrowLocalVolume(a mesos.AgentID, volume mesos.Resource, addition mesos.Resource) *master.Call {

  • return &master.Call{
  • Type: master.Call_GROW_VOLUME,
  • GrowVolume: &master.Call_GrowVolume{
  • AgentID: &a,
  • Volume: volume,
  • Addition: addition,
  • },
  • } +}

  • +// ShrinkLocalVolume shrinks a persistent volume on an agent's ROOT or PATH disks. The request is forwarded +// asynchronously to the Mesos agent where the persistent volume is located. +func ShrinkLocalVolume(a mesos.AgentID, volume mesos.Resource, subtract mesos.Value_Scalar) *master.Call {

I'll make it a pointer. Then should I just rename it to GrowVolume/ ShrinkVolume? Currently it supports only local volumes but me may extend it to support external volumes in the future.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mesos/mesos-go/pull/354#discussion_r203818174, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLNWkO781DWvBzb6AXsMFyIrFHC3Xks5uIMhSgaJpZM4VVail .

chhsia0 commented 6 years ago

@jdef Done. PTAL.