search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

Add go get to make install to fix a missing dependency #355

Closed philipnrmn closed 6 years ago

philipnrmn commented 6 years ago

Without the go get ./... step, a newly configured environment does not automatically import the ffjson and uuid libraries, causing make install to fail due to missing dependencies.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.4%) to 58.367% when pulling 7a7a971e7bf45505c27554a249e5be3a0f6bedd0 on philipnrmn/goget into 29de6ff97b48c29cb5ac07029ed75186e5ba0eed on master.

jdef commented 6 years ago

Thanks for the PR! It sounds like the dependencies are out of date. make sync should get everything needed to build the project. Instead of executing go-get, I think we should fix the dependencies so that make sync works as expected.