Bump v1 proto 0aa3df5147e7

mesos / mesos-go

Go language bindings for Apache Mesos

Apache License 2.0

544 stars 146 forks source link

Bump v1 proto 0aa3df5147e7 #375

Closed jdef closed 5 years ago

jdef commented 5 years ago

cc @bamarni

jdef commented 5 years ago

Not very happy with the 200 response code for the new update-framework scheduler call.

See https://github.com/apache/mesos/commit/2453aa4f2dd19b861b082e10caef73f7747fd0c4#r34257625

[EDIT]

If mesos sends a content-length: 0 header along with the 200 OK then I can live with that

jdef commented 5 years ago

CI/ffjson complaints:

Error: Go Run Failed for: master/ffjson-inception382575486/ffjson-inception228198048.go
STDOUT:
STDERR:
# github.com/mesos/mesos-go/api/v1/lib/master
master/master.pb.go:8404:58: m.MaxGracePeriod.ProtoSize undefined (type *types.Duration has no field or method ProtoSize)
master/master.pb.go:11529:23: m.MaxGracePeriod.ProtoSize undefined (type *types.Duration has no field or method ProtoSize)
:
make[1]: *** [ffjson] Error 1

coveralls commented 5 years ago

Coverage increased (+0.02%) to 59.499% when pulling 0e6cb48d88c8e48e910b4b32beb6aa18273e3258 on jdef:bump_v1_proto_0aa3df5147e7 into 3c2ae7f09d530e0ecd62acd2c31a4d73ed9bdf55 on mesos:master.

coveralls commented 5 years ago

Coverage increased (+0.02%) to 59.499% when pulling 0e6cb48d88c8e48e910b4b32beb6aa18273e3258 on jdef:bump_v1_proto_0aa3df5147e7 into 3c2ae7f09d530e0ecd62acd2c31a4d73ed9bdf55 on mesos:master.