search

mesos / mesos-go

Go language bindings for Apache Mesos
Apache License 2.0
545 stars 146 forks source link

[WIP] Go module support #378

Closed nfnt closed 4 years ago

nfnt commented 5 years ago

Use Go modules, but keep a vendor directory for older versions of Go.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.2%) to 58.374% when pulling e9b26f3ca8d5e2c3b05377cbb44366c8b7251cd6 on nfnt:nfnt/go-mod into 56ac038085ac996051390598b156bff1c6ef0d3d on mesos:master.

jdef commented 5 years ago

Thanks for investigating this. I briefly skimmed the changed files and noticed that the nested, vendored deps were converted to a top level deps, of a top level mod. This isn't consistent with keeping v0 api deps separate from v1 api deps, or separating the deps of the lib from the cmd examples.

This repo is ripe for an overhaul, part of that should include support for gomods. Let's discuss a more comprehensive plan before moving forward with this PR.

nfnt commented 5 years ago

Yes, I did convert them temporarily. The main work is making sure that Travis is still working as expected and steps that were depending on govendor don't break/ are changed accordingly. Once that's done, I wanted to separate the deps again.