search

mesos / mr-redis

Redis on Apache Mesos
Apache License 2.0
127 stars 32 forks source link

Fix the issue that invalid instance name (empty or null) can be created #64

Open zousheng opened 7 years ago

zousheng commented 7 years ago

Fix the issue https://github.com/mesos/mr-redis/issues/63

dhilipkumars commented 7 years ago

@zousheng Thanks for the PR?

could you run gofmt golint and go vet in the code? we could get a cleaner new code.

Also are you using redis-proxy in your project?

zousheng commented 7 years ago

Sure, I tried to use it in our production, and found few issues 1) I changed the proxy part to support proxy multiple redis servers, and store the mappings in the zk. In production the broken pipe issue occurred, and I added one io try catch for io.copy() method. and add the test-on-borrow on client, then it seems solved for now

2) In test environment, we tried to shutdown machine first to test the failover, it turns out master-slave failover not working, it's only working when I stop or kill the container, so this is very critical issue. Haven't checked the code yet. Would you please give some advice? Thanks