search

mesos / storm

Storm on Mesos!
Apache License 2.0
139 stars 66 forks source link

Change LocalFileServer to allow respecting storm.yaml's nimbus.host #167

Closed erikdw closed 8 years ago

erikdw commented 8 years ago

Prior to this the only way to configure the URL that LocalFileServer listens to is via MESOS_NIMBUS_HOST environment variable. That differs from the behavior of the core MesosNimbus which supports that env variable, as well as the nimbus.host field in the storm.yaml config. So update the code to make them equally configurable.

erikdw commented 8 years ago

@drewrobb : can you please review when you have a chance? Thanks!

drewrobb commented 8 years ago

LGTM!

drewrobb commented 8 years ago

looks like build is failing for unrelated reasons

erikdw commented 8 years ago

@drewrobb : thanks for the review. Yeah, looks like the hardcoded docker-engine version is at fault, I removed it in another commit that I suppose I'll just piggy-back into this PR. My first build worked just fine: https://travis-ci.org/mesos/storm/builds/152560889 Another build is running right now because I updated the commit description.

bigdata-user commented 8 years ago

@erikdw storm on mesos(0.28.2) cannot support zookeeper,so the mesos-master isn't HA!

erikdw commented 8 years ago

@zhanghangchina : this isn't the right place to make that comment @zhanghangchina. Please open an issue if you have a problem.