search

mesos / storm

Storm on Mesos!
Apache License 2.0
139 stars 66 forks source link

Change deprecated `nimbus.host`-> `nimbus.seeds` #189

Closed eyalzek closed 7 years ago

eyalzek commented 7 years ago

A change introduced in v1.0.0 of apache storm. Using nimbus.host will still work but will produces the following error: Using deprecated config nimbus.host for backward compatibility. Please update your storm.yaml so it only has config nimbus.seeds https://issues.apache.org/jira/browse/STORM-1185

erikdw commented 7 years ago

@eyalzek : have you tested this suggested change? I don't think it's so easy, the MesosNimbus code makes assumptions that it can use nimbus.host to drive various behaviors, and because of the change from single string to an array, it's not quite as simple as changing the code to look at the alternate parameter name.

Also, pedantically, that's a "warning" message, not an actual "error" (they have different semantic meanings).

eyalzek commented 7 years ago

Yes, that is indeed a warning and not an error, my bad. I changed this setting on my storm.yaml to get rid of these warning and it's working ok. Since I've seen that on the README here it's still referencing nimbus.host I figured it should be updated. I might not be aware of the full consequences of it though.

erikdw commented 7 years ago

@eyalzek : ahh, yep, it's a bit more nuanced. Not rocket science or anything, but requires a bit of effort to change the code too. I've filed issue #190 for fixing MesosNimbus to support nimbus.seeds, so I'm gonna close this PR.