search

mesos / storm

Storm on Mesos!
Apache License 2.0
138 stars 66 forks source link

Add the function of constraints based on mesos-attributes #196

Closed fuji-151a closed 6 years ago

fuji-151a commented 7 years ago

I want to constrain the slave nodes which bootstrap supervisor. Currently, MesosNimbus only support the constraints per host using mesos.allowed.hosts or mesos.disallowed.hosts. This PR provides the function of constraints based on mesos-attributes.

http://mesos.apache.org/documentation/latest/attributes-resources/

An attribute value supports three different types: scalar, range, or text. However, this PR only supports the attribute values of text type.

Please confirm this PR. Thank you

erikdw commented 7 years ago

@fuji-151a : thanks for the PR -- I don't have time to review this right now, I'm allocating time next week for this. I hope that is ok.

erikdw commented 7 years ago

@fuji-151a : did you see our replies? I'm definitely interested in having this change, but we just need to ensure it's easily supportable and usable.

fuji-151a commented 7 years ago

Thanks for the review @erick. I'll try to modify this code based on your reviews. I'll send pull request again. Then, would you review this again.

erikdw commented 7 years ago

@fuji-151a : yeah, you should just update this PR with your changes, not a new PR please.

erikdw commented 7 years ago

@fuji-151a : any update?

fuji-151a commented 7 years ago

@erikdw I'm dividing classes to write test code now. But, I'm busy and have not space time... sorry... I'll update this PR in this month. Please wait for a while.

erikdw commented 7 years ago

@fuji-151a : no worries, thanks for letting me know!

fuji-151a commented 7 years ago

Thanks for the review @erick. I'll try to modify this code based on your reviews. And I haven't modified README.md yet. I'll try to modify this too.

erikdw commented 6 years ago

@fuji-151a : I'm closing this for now, as the requested documentation updates haven't been done yet. At this point this is not yet mergeable -- the PR description, the commit messages, the README, and the comments in the code would all have to make it a lot more clear what is being done, why it is being done, etc.