search

mesos / storm

Storm on Mesos!
Apache License 2.0
138 stars 66 forks source link

Prevent supervisor suicide epidemic #208

Closed erikdw closed 7 years ago

erikdw commented 7 years ago

Fixes #202. These changes are all by @michaelmoss, and this was all reviewed and tested in #204, I'm just creating a new PR with a clean commit history so I can merge it straight away.

erikdw commented 7 years ago

Thanks @michaelmoss for the work on this and dealing with all the follow-ups!

erikdw commented 7 years ago

Notably, this PR breaks support for Storm 1.0.0, 1.0.1, and 1.0.2 in this project (because of the regression / loss of backwards compatibility detailed in STORM-2690). We've intentionally done this so that forward progress can be made.

JessicaLHartog commented 7 years ago

@erikdw Should we tag just before this set of commits so that it's easier for users of Storm 1.0.[0..2] can more readily leverage this project? Or do you think the release before this sufficient?

erikdw commented 7 years ago

@JessicaLHartog : good idea. Let's think about what to call the name, we can always tag a previous commit later:

I'm going to try to generate a new release from this, and then merge in your scheduling change (#200), and generate a new release after that. PTO FTW! 😭

erikdw commented 7 years ago

v0.2.3 released: