search

mesos / storm

Storm on Mesos!
Apache License 2.0
138 stars 66 forks source link

Nimbus should kill already-launched logviewers if relaunched with `sidecar.enabled=false` #239

Open srikanth-viswanathan opened 6 years ago

srikanth-viswanathan commented 6 years ago

Nimbus should kill already-launched logviewers if re-launched with mesos.logviewer.sidecar.enabled=false.

The pertinent use case is: If Nimbus is initially launched with mesos.logviewer.sidecar.enabled=true (or absent, which will give it the default true value) and then re-launched with mesos.logviewer.sidecar.enabled=false. logviewers launched prior to the re-launch are never reaped. Nimbus should reap them and release the resources back to Mesos.