mesosphere-backup / deimos

Mesos containerizer hooks for Docker
Apache License 2.0
249 stars 26 forks source link

Mesos environment variables not set when task_info specified #43

Open boompig opened 10 years ago

boompig commented 10 years ago

If task_info is used instead of executor_info (see here), then executor() return value is None, which makes the return value of needs_observer() True. This causes Mesos environment variables to not be set.

The code for that can be found here.

Is this the expected behaviour? It does not seem to be, because for me specifying task_info implies I want to create a new executor to work with it, rather than attaching to an existing one.

Also, the documentation makes reference to TaskInfo rather than ExecutorInfo here, which seems to suggest that this is the preferred way.