search

mesosphere-backup / deimos

Mesos containerizer hooks for Docker
Apache License 2.0
249 stars 26 forks source link

More than just docker? #44

Open hub-cap opened 10 years ago

hub-cap commented 10 years ago

Howdy,

Id like to use deimos to create OpenVZ containers. Would you be open to me hacking up deimos to work with more than one containerizer? Ive looked over the code a good bit and it seems like a good bit of the code is abstracted in a way that it wouldnt be hard to accomplish said task. Whaddya think?

Also i can attempt to bribe you with beer and tapas!

tnachen commented 10 years ago

Hi hub-cap, we definitely welcome PRs. Feel free to fork and open a PR when you have it done.

hub-cap commented 10 years ago

Right on. I just didnt want to do a bunch of work to find out yall wanted to keep this "docker centric". If thats not the case then its ON!

solidsnack commented 10 years ago

At present, Deimos just hands all container infos to the Docker containerizer. A while back, I did a refactor, where all the proto parsing was handled by a router that looked at the image URLs (or looked up these URLs, based on the container ID) to pick a containerizer implementation.

Maybe a reasonable thing to do would be to store the image URL in the Deimos state? Then Deimos will know which sub-containerizer to use to route usage.