search

mesosphere-backup / etcd-mesos

self-healing etcd on mesos!
Apache License 2.0
67 stars 19 forks source link

Add advertise-address flag to handle the scheduler being behind a NAT #102

Open lclarkmichalek opened 8 years ago

lclarkmichalek commented 8 years ago

In cases where the Docker daemon puts containers behind a NAT, the agent needs to use a different address to the address that is bound on to get the executor and related binaries. This change adds an 'advertise-address' flag that allow you to specify this.

I would have loved to call this flag address, and move the current address flag to bind-address or something, but I don't know how compatible that would be?

jdef commented 8 years ago

thanks for the PR, left some comments

lclarkmichalek commented 8 years ago

Not 100% sure that's exactly what you wanted. Used the explicitAdvertise var to indicate if the advertiseAddress flag was ever set to anything different.