search

mesosphere-backup / etcd-mesos

self-healing etcd on mesos!
Apache License 2.0
67 stars 19 forks source link

Allow authentication to clusters #103

Open lclarkmichalek opened 8 years ago

lclarkmichalek commented 8 years ago

Enabling auth on the cluster was previously causing the health checks to fail, as the etcd client was not setting credentials. This adds a Username and Password to config.Node, and uses those (if set) to auth to the cluster

matthewdfuller commented 7 years ago

@lclarkmichalek - thanks for making this. We're running etcd via Marathon (similar to the sample in the readme). To enable auth and take advantage of these changes, would we have to update the cli flags passed in? Or are there environment variables we can use?

EDIT: in other words, it seems like we'd need to adjust this file as well.

lclarkmichalek commented 7 years ago

This PR isn't being used in production (by me at least), so you may need to make changes. But yeah, you'll need to pass in some extra params.

pires commented 7 years ago

@jdef what are your thoughts on adding this functionality, plus TLS-based authentication?