Remove deprecated safety.

mesosphere-backup / etcd-mesos

self-healing etcd on mesos!

Apache License 2.0

68 stars 19 forks source link

Remove deprecated safety. #119

Open pires opened 7 years ago

pires commented 7 years ago

Fixes #56

Performed the following tests:

[x] (a) start up an etcd cluster; make sure that the number of expected servers is brought online
[x] (b) kill a server, make sure that etcd-mesos brings it back online
[x] (c) kill a node; make sure that etcd-mesos can cope with that (assuming that normal cluster size is >= 3 servers)
[ ] ~~(d) bring the node back online; etcd should launch a server on it~~

jdef commented 7 years ago

would like, at least, manual fault injection testing to verify that this change doesn't break anything

pires commented 7 years ago

What manual fault injection tests are you specifically referring to? I ran the ones identified above.

jdef commented 7 years ago

tyler used to execute exhaustive manual fault injection while testing changes like this. we don't have anything automated yet to execute those tests. According to notes in #56:

It's probably safe to remove now, but we need to do fault injection without it to increase our confidence.

Simple fault injection testing is probably not enough to have confidence in this change.