search

mesosphere-backup / etcd-mesos

self-healing etcd on mesos!
Apache License 2.0
67 stars 19 forks source link

Use configurable framework name #55

Closed spacejam closed 9 years ago

spacejam commented 9 years ago

@ConnorDoyle

jdef commented 9 years ago

doesn't this break GetPeersFromState? https://github.com/mesosphere/etcd-mesos/blob/859ed76f799d3500398f55886127d1e1abae7ed2/rpc/state.go#L103

On Fri, Sep 18, 2015 at 8:31 PM, Tyler Neely notifications@github.com wrote:

@ConnorDoyle https://github.com/ConnorDoyle

You can view, comment on, or merge this pull request online at:

https://github.com/mesosphere/etcd-mesos/pull/55 Commit Summary

  • Use configurable framework name

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/mesosphere/etcd-mesos/pull/55.

jdef commented 9 years ago

mesos-0.24 supports framework labels, so you could tag the framework with "etcd-"+clusterName by adding a k/v pair to the labels section, and then search for that in GetPeersFromState. pre-0.24 you're SOL

On Sat, Sep 19, 2015 at 1:43 AM, James DeFelice james@mesosphere.io wrote:

doesn't this break GetPeersFromState?

https://github.com/mesosphere/etcd-mesos/blob/859ed76f799d3500398f55886127d1e1abae7ed2/rpc/state.go#L103

On Fri, Sep 18, 2015 at 8:31 PM, Tyler Neely notifications@github.com wrote:

@ConnorDoyle https://github.com/ConnorDoyle

You can view, comment on, or merge this pull request online at:

https://github.com/mesosphere/etcd-mesos/pull/55 Commit Summary

  • Use configurable framework name

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/mesosphere/etcd-mesos/pull/55.

spacejam commented 9 years ago

@jdef good catch! I'll just pass along the actual framework name to retain backwards compatability

spacejam commented 9 years ago

This has been more fully implemented, PTAL!

ConnorDoyle commented 9 years ago

:shipit:

jdef commented 9 years ago

minor comments, otherwise lgtm