search

mesosphere-backup / etcd-mesos

self-healing etcd on mesos!
Apache License 2.0
67 stars 19 forks source link

initial revision of contribution guidelines #81

Closed jdef closed 9 years ago

jdef commented 9 years ago
jdef commented 9 years ago

@spacejam PTAL

spacejam commented 9 years ago

I've heard a bit of negative feedback from people external to mesosphere about the guidelines used for eg mesos-dns. I'm happy with this doc, but for a relatively large definition of "non-trivial". I think we should only have to refer people to these in particularly egregious cases, otherwise we'll discourage contribution.

I'm happy with this being merged as-is, but we need to keep in mind that our interactions with contributors need to be framed around the goal of maximizing mutually beneficial future contribution.

jdef commented 9 years ago

The initial guidelines for mesos-dns were much heavier -- is that what people were concerned about? If so that doesn't surprise me. This newer, lighter form is much more forgiving.

Agreed w/ respect to maximizing future contribution.

On Wed, Nov 11, 2015 at 12:28 PM, Tyler Neely notifications@github.com wrote:

I've heard a bit of negative feedback from people external to mesosphere about the guidelines used for eg mesos-dns. I'm happy with this doc, but for a relatively large definition of "non-trivial". I think we should only have to refer people to these in particularly egregious cases, otherwise we'll discourage contribution.

I'm happy with this being merged as-is, but we need to keep in mind that our interactions with contributors need to be framed around the goal of maximizing mutually beneficial future contribution.

— Reply to this email directly or view it on GitHub https://github.com/mesosphere/etcd-mesos/pull/81#issuecomment-155854199.

spacejam commented 9 years ago

Yeah, I think it boiled down to someone wanting to help but us making it hard.