mesosphere-backup / hdfs-deprecated

[DEPRECATED] This project is deprecated. It will be archived on December 1, 2017.
Apache License 2.0
147 stars 52 forks source link

Add fs.s3n.awsAccessKeyId and fs.s3n.awsSecretAccessKey to mesos-site.xml and include them in core-site.xml #106

Open rolandomanrique opened 9 years ago

rolandomanrique commented 9 years ago

Add configuration parameters for AWS key and secret to be used in core-site.xml. Resulting XML in core-site.xml should look like this:

    <property>
     <name>fs.s3n.awsAccessKeyId</name>
     <value>{AWS_ACCESS_KEY}</value>
    </property>

    <property>
     <name>fs.s3n.awsSecretAccessKey</name>
     <value>{AWS_SECRET_KEY}</value>
    </property>
abhay-agarwal commented 9 years ago

Any *-site.xml files in the conf directory will automatically be built into the tarball so users can write this on their own.

elingg commented 9 years ago

@abhay-agarwal, Actually they are referring to distributing core-site.xml with configserver so it picks up the environment variables which we don't yet do.

elingg commented 9 years ago

Note there is a security conern with using these parameters so we may not want these defined by default. Per @brndnmtthws "One other note: you may not want to define the fs.s3.aws* parameters. HDFS's s3:// protocol is for S3-backed block-based storage, which is usually not what people want. If you omit the params, people won't be able to use s3:// by accident, and thereby messing up whatever's in that bucket. There's more on this here: https://wiki.apache.org/hadoop/AmazonS3". @rmvz, let us know whether you think it's worth having these parameters by default due to this security concern.

elingg commented 9 years ago

Talked to @rmvz, and he is not using the parameter for block based storage in order to avoid touching other resources by using "fs.s3n.aws" instead of “fs.s3.aws.”