search

mesosphere-backup / hdfs-deprecated

[DEPRECATED] This project is deprecated. It will be archived on December 1, 2017.
Apache License 2.0
147 stars 52 forks source link

configs now use properties instead of env and it is tested #232

Closed kensipe closed 8 years ago

kensipe commented 8 years ago

adding tests to config that sys properties overrides xml

kensipe commented 8 years ago

@elingg @gabrielhartmann looking for some love

gabrielhartmann commented 8 years ago

@kensipe: LGTM if HDFS has had its integration tests run.

kensipe commented 8 years ago

ok.. thx @gabrielhartmann to your point... I will test in the env and merge upon a pass

elingg commented 8 years ago

One comment is that this only has an effect on the scheduler environment variables. I think data dir is a bad example because it is only used by the scheduler. On that note, of course we should improve our code to be able to set executor environment variables as well. We may want to pass them through the scheduler to the executors.

kensipe commented 8 years ago

@elingg I plan to have env vars work through the system by tomorrow. I expect to remove that clause and provide a list values that can be changed. In the mean time, I'll look for a better example.

kensipe commented 8 years ago

readme updates resolved... tested... merging!

elingg commented 8 years ago

Sounds great @kensipe