mesosphere-backup / hdfs-deprecated

[DEPRECATED] This project is deprecated. It will be archived on December 1, 2017.
Apache License 2.0
147 stars 52 forks source link

Sys Props on the scheduler carry forward to executors #235

Closed kensipe closed 8 years ago

kensipe commented 8 years ago
kensipe commented 8 years ago

@gabrielhartmann @elingg looking for more love. I still need to test this on dcos. It looks like add we need. following that test I will refactor some xml (remove values) and add docs. ENV vars should be the preferred way to configure several things (like framework name, etc). I will also add docs + update universe with new approach.

elingg commented 8 years ago

Thank you, @kensipe! Began the review at least. See my above comments.

kensipe commented 8 years ago

@elingg I took a different approach with predicates which I think resolves all of your list concerns, removes some code and feels better in general.

kensipe commented 8 years ago

@elingg @gabrielhartmann looking for another review. I've tested this it works HOWEVER...

elingg commented 8 years ago

Let me take a look @kensipe

elingg commented 8 years ago

I like this approach much better @kensipe! Looks pretty awesome. A few small comments above. Also please test on pure Mesos as we discussed to make sure the framework-name setting works as a sanity check.

kensipe commented 8 years ago

ok... all feedback applied. I'm getting ready to test on standard mesos. if good.. I will merge.

elingg commented 8 years ago

Sounds good