search

mesosphere-backup / hdfs-deprecated

[DEPRECATED] This project is deprecated. It will be archived on December 1, 2017.
Apache License 2.0
147 stars 52 forks source link

adding details on how to config the HDFS FW #238

Closed kensipe closed 8 years ago

kensipe commented 8 years ago

@gabrielhartmann it would be nice to get a review on these docs

gabrielhartmann commented 8 years ago

Minor copy editing stuff. The only thing I'm not crazy about is the use of a string format convention to indicate overrides. Could we have a config flag, that indicates we are using going to use overrides and then go look for environment variables in the format you described? I just prefer being explicit about the override behavior as it's potentially surprising.

No comments are blocking. LGTM.

kensipe commented 8 years ago

thanks! pertaining to your last comment... I want to completely remove the meso-site.xml. All configurations should be standardized across all of our frameworks. The common approach for most is to use system env vars are args. This is using env vars. When we remove mesos-site.xml then technically it will not be an override of an xml, it will be an override of the default which would be expected behavior for anyone that uses an env var.

elingg commented 8 years ago

Completely agree with removing mesos-site.xml although it will be a significant change. Nice work @kensipe and @gabrielhartmann