search

mesosphere-backup / sssp

S3 Proxy Mesos Framework
61 stars 10 forks source link

Route priority bugfix #5

Closed ConnorDoyle closed 10 years ago

ConnorDoyle commented 10 years ago

Added scalatest as a dependency in the test scope, used same to test route priority logic. Here we see the failed test output pre-bugfix:

[sssp] $ test-only mesosphere.sssp.test.RoutesSpec
[info] Compiling 1 Scala source to /Users/connor/projects/mesosphere/sssp/target/scala-2.10/test-classes...
[info] RoutesSpec:
[info] RoutesSpec
[info] - should select the deepest (most specific) route for a path *** FAILED ***
[info]   Some((List(a, b),mesosphere.sssp.S3Notary@64fba3f6)) did not equal Some((List(a, b, c),mesosphere.sssp.S3Notary@4180874)) (RoutesSpec.scala:27)
[error] Failed: Total 1, Failed 1, Errors 0, Passed 0
[error] Failed tests:
[error]     mesosphere.sssp.test.RoutesSpec

And post-bugfix:

[sssp] $ test-only mesosphere.sssp.test.RoutesSpec
[info] Compiling 1 Scala source to /Users/connor/projects/mesosphere/sssp/target/scala-2.10/classes...
[info] Compiling 1 Scala source to /Users/connor/projects/mesosphere/sssp/target/scala-2.10/test-classes...
[info] RoutesSpec:
[info] RoutesSpec
[info] - should select the deepest (most specific) route for a path
[info] Passed: Total 1, Failed 0, Errors 0, Passed 1
ConnorDoyle commented 10 years ago

@solidsnack Fixed formatting

ConnorDoyle commented 10 years ago

@solidsnack Minimized diff in bugfix site