search

mesosphere / chronos-pkg

Apache License 2.0
5 stars 16 forks source link

Allowing optional JVM parameters to be set #8

Closed sdwr98 closed 8 years ago

sdwr98 commented 9 years ago

We have a need to set some custom JVM parameters on the Chronos process (for logging configuration, etc.), so it would be nice to be able to set these in the init script rather than having to patch the /usr/bin/chronos script.

j1n6 commented 9 years ago

+1

lloesche commented 9 years ago

How about duplicating what https://github.com/mesosphere/marathon/blob/master/bin/marathon-framework does with JAVA_OPTS? It seems the two scripts once had the same codebase but only marathon-framework evolved.

I would prefer JAVA_OPTS as it's the standard way of adding jvm args via the environment. I also recommend looking at https://github.com/mesosphere/marathon-pkg/blob/master/marathon.service where we introduced EnvironmentFile=-/etc/sysconfig/marathon. This essentially allows us to change JVM parameters at startup and is the RedHat recommended way of doing so (http://fedoraproject.org/wiki/Packaging%3aSystemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files).

j1n6 commented 9 years ago

I think your suggestion looks promising. We should keep framework package and configuration standardized.

On 11 May 2015, at 18:52, Lukas Lösche notifications@github.com wrote:

How about duplicating what https://github.com/mesosphere/marathon/blob/master/bin/marathon-framework does with JAVA_OPTS? It seems the two scripts once had the same codebase but only marathon-framework evolved.

I would prefer JAVA_OPTS as it's the standard way of adding jvm args via the environment. I also recommend looking at https://github.com/mesosphere/marathon-pkg/blob/master/marathon.service where we introduced EnvironmentFile=-/etc/sysconfig/marathon. This essentially allows us to change JVM parameters at startup and is the RedHat recommended way of doing so (http://fedoraproject.org/wiki/Packaging%3aSystemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files).

— Reply to this email directly or view it on GitHub.

lloesche commented 9 years ago

@sdwr98 do you want to update the PR? If you currently don't have the time I can create one. Let me know.

sdwr98 commented 9 years ago

@lloesche Done - thanks for the suggestions

lloesche commented 8 years ago

LGTM 👍