mesosphere / kudo-cassandra-operator

KUDO Cassandra Operator
https://kudo.dev
Apache License 2.0
10 stars 3 forks source link

Revert "Started new branch for recovery controller" #110

Closed porridge closed 4 years ago

porridge commented 4 years ago

Reverts mesosphere/kudo-cassandra-operator#96 in an attempt to de-flake the tests.

The kuttl tests failed on every commit since it was merged:

The change itself: https://github.com/mesosphere/kudo-cassandra-operator/commit/9265e3022f3aed7e8fee64905ce51a87d8977ea1

My two PRs:

porridge commented 4 years ago

I'm not sure how keeping master red is going to help? https://github.com/kudobuilder/kudo/blob/master/CONTRIBUTING.md#general-guidelines

zmalik commented 4 years ago

@porridge I don't see any guidelines for reverts 🤔 https://github.com/kudobuilder/kudo/blob/master/CONTRIBUTING.md#general-guidelines I see for green builds which is the intention and priority here