search

mesosphere / kudo-cassandra-operator

KUDO Cassandra Operator
https://kudo.dev
Apache License 2.0
10 stars 3 forks source link

docker.sh is changing go.mod #112

Open porridge opened 4 years ago

porridge commented 4 years ago

It seems that this step in docker.sh:

Step 9/9 : RUN go get golang.org/x/tools/cmd/goimports
 ---> 384b875e43e0

Is changing go.mod which then makes run-pre-checks.sh fail:

Changes found after running one of the previous steps.
Please make sure you follow the instructions in .github/pull_request_template.md
before sending a pull request.
 M images/bootstrap/go.mod
 M images/bootstrap/go.sum
diff --git a/images/bootstrap/go.mod b/images/bootstrap/go.mod
index edcf478..cad7dce 100644
--- a/images/bootstrap/go.mod
+++ b/images/bootstrap/go.mod
@@ -11,7 +11,7 @@ require (
        github.com/stretchr/testify v1.4.0
        golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37 // indirect
        golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a // indirect
-       golang.org/x/sys v0.0.0-20200509044756-6aff5f38e54f // indirect
+       golang.org/x/sys v0.0.0-20200513112337-417ce2331b5c // indirect
        gotest.tools/gotestsum v0.4.2 // indirect
        k8s.io/api v0.17.3
        k8s.io/apimachinery v0.17.3
diff --git a/images/bootstrap/go.sum b/images/bootstrap/go.sum
index 64e3b49..ac0b3fb 100644
--- a/images/bootstrap/go.sum
+++ b/images/bootstrap/go.sum
@@ -202,6 +202,8 @@ golang.org/x/sys v0.0.0-20200501145240-bc7a7d42d5c3 h1:5B6i6EAiSYyejWfvc5Rc9BbI3
 golang.org/x/sys v0.0.0-20200501145240-bc7a7d42d5c3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200509044756-6aff5f38e54f h1:mOhmO9WsBaJCNmaZHPtHs9wOcdqdKCjF6OPJlmDM3KI=
 golang.org/x/sys v0.0.0-20200509044756-6aff5f38e54f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20200513112337-417ce2331b5c h1:kISX68E8gSkNYAFRFiDU8rl5RIn1sJYKYb/r2vMLDrU=
+golang.org/x/sys v0.0.0-20200513112337-417ce2331b5c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/text v0.0.0-20160726164857-2910a502d2bf/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
porridge commented 4 years ago

Workaround: git checkout go.???

porridge commented 4 years ago

I think we should switch to golangci-lint instead, like for core KUDO.