search

mesosphere / kudo-cassandra-operator

KUDO Cassandra Operator
https://kudo.dev
Apache License 2.0
10 stars 3 forks source link

Disable the Prometheus exporter by default #131

Closed nfnt closed 4 years ago

nfnt commented 4 years ago

The Prometheus exporter requires additional CRDs that aren't available in many default cluster environments. To avoid errors in this case, the PROMETHEUS_EXPORTER_ENABLED has been changed from opt-out to opt-in.

porridge commented 4 years ago

@nfnt please read the entirety of section https://github.com/mesosphere/kudo-cassandra-operator/pull/131/files#diff-609282fcf45c95a88e8b87096f80263aR44-R58 and re-write it to make sense. This guide was written for people who want this enabled so sentence such as "you only need to worry about this if you enabled it" has little sense :-)

There is at least one other sentence in this paragraph which assumes the previous default. Please fix appropriately.

zmalik commented 4 years ago

@nfnt we are testing metrics in the sanity test can you enable monitoring for sanity test?

nfnt commented 4 years ago

Thanks for catching and correcting that @zmalik!