search

mesosphere / kudo-cassandra-operator

KUDO Cassandra Operator
https://kudo.dev
Apache License 2.0
10 stars 3 forks source link

Add polling to ext service test #150

Closed ANeumann82 closed 4 years ago

ANeumann82 commented 4 years ago

Fixes #146

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

ANeumann82 commented 4 years ago

My only concern is that "false is not true" is not a great message when a test fails. The Infofs do help, but they have the downside of spamming the output. I wonder whether we could come up with something even better? Perhaps return a structured object from the func and do a more complex assertion (which hopefully will have a more meaningful error message)?

I mostly agree. I tried to figure something out, but it's all pretty annoying. The structured object return might be an option, but it adds a lot of complexity. I don't think the log spam is too much, i've added a bit more detailed logs and removed the spammy output that was there before.