search

mesosphere / marathon-client

Java Integration Library for Mesosphere Marathon
Apache License 2.0
17 stars 12 forks source link

Fetchable Needs to be Based on Marathon API Artifact #22

Closed kensipe closed 4 years ago

kensipe commented 4 years ago

Fixes: https://jira.d2iq.com/browse/COPS-6067

This has always been incorrect in marathon-client The internal state of Marathon uses FetchUri which has outputFile,

https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/marathon/raml/AppConversion.scala#L113

however the RAML defines the external API and the RAML defines fetch as artifact.Artifact[]

https://github.com/mesosphere/marathon/blame/master/docs/docs/rest-api/public/api/v2/types/app.raml#L194-L195

The RAML definition is 4 years old... and the marathon client definition is 3 years old https://github.com/mesosphere/marathon-client/commit/5a126bf032c79e448c694f17d9167602a3e84254

The marathon-client needs to be changed to support https://github.com/mesosphere/marathon/blob/master/docs/docs/rest-api/public/api/v2/types/artifact.raml

This fixes the issue!

Signed-off-by: Ken Sipe kensipe@gmail.com