Use self.host property once in get_event_stream

mesosphere / marathon-lb

Marathon-lb is a service discovery & load balancing tool for DC/OS

Apache License 2.0

450 stars 300 forks source link

Use self.host property once in get_event_stream #640

Closed sharego closed 5 years ago

sharego commented 5 years ago

self.host cycles through available Marathon URLs, and it was accessed twice in get_event_stream, which made it access the same Marathon instance, if two URLs were supplied, which is especially profound if the instance being accessed over and over again is down.

mesosphere-ci commented 5 years ago

Can one of the admins verify this patch?

mesosphere-ci commented 5 years ago

Can one of the admins verify this patch?

mesosphere-ci commented 5 years ago

Can one of the admins verify this patch?

jkoelker commented 5 years ago

ok to test

ichernetsky commented 5 years ago

@sharego, thanks a lot for your contribution and your patience. I reviewed the patch, and I will make sure that it gets merged in no time.