mesosphere / marathon

Deploy and manage containers (including Docker) on top of Apache Mesos at scale.
https://mesosphere.github.io/marathon/
Apache License 2.0
4.07k stars 845 forks source link

Docker 'parameters' constrained to single value per key #970

Closed LLParse closed 9 years ago

LLParse commented 9 years ago

map[string, string] doesn't work in this case because many docker parameters may be passed in multiple times. list(tuple(string, string)) or map[string, list(string)] would fix

For example: docker run --rm -P -e HEAP_MIN=512M -e HEAP_MAX=1G -e OTHEROPTS=blah blah/java_app

https://github.com/mesosphere/marathon/blob/master/src/main/scala/mesosphere/marathon/api/v2/json/Formats.scala#L167

ConnorDoyle commented 9 years ago

You're right, this was an oversight in the implementation.

tnachen commented 9 years ago

+1 we need to get this fixed for a number of folks

ConnorDoyle commented 9 years ago

Submitted PR #1003.