mesosphere / mesos-deb-packaging

Mesos package for Debian, Ubuntu, CentOS, RHEL, and Fedora
Other
58 stars 67 forks source link

What is the realpath binary used? #73

Closed radekg closed 8 years ago

radekg commented 8 years ago

There was a change done 4 days ago: https://github.com/mesosphere/mesos-deb-packaging/commit/f7bf8e883ddb01e66ac98c27420846503cbd46ac#diff-4b50484efae8f6de7189b46016875ddaR168

I wonder, what is that realpath? I'm looking at man for realpath: http://manpages.ubuntu.com/manpages/trusty/man1/realpath.1.html and I can't see any documentation for --relative-to. Where does it come from?

Also, neither docker ubuntu:precise, neither ubuntu:trusty has realpath available. This prevents Mesos from building inside of the Docker container.

karya0 commented 8 years ago

Apparently, this option for realpath first came in Utopic (http://manpages.ubuntu.com/manpages/utopic/man1/realpath.1.html) which means it's not available for trusty or precise. I have reverted the change for now. Will generate a new PR.

radekg commented 8 years ago

Thank you.

karya0 commented 8 years ago

@radekg: Can you take a look at https://github.com/mesosphere/mesos-deb-packaging/pull/74/ and see if that would work?

radekg commented 8 years ago

I can test this shortly.

radekg commented 8 years ago

Tried on precise and went to make successfully. It should work perfectly fine on trusty and higher.

radekg commented 8 years ago

I see this has been merged. 👍