Updated logging regarding new masters.

mesosphere / mesos-dns

DNS-based service discovery for Mesos.

https://mesosphere.github.com/mesos-dns

Apache License 2.0

484 stars 137 forks source link

Updated logging regarding new masters. #510

Closed armandgrillet closed 5 years ago

armandgrillet commented 6 years ago

The detection of new masters now results in a log line that is displayed even with a disabled verbose mode.

The idea behind this change is that this event is important and not common thus it should be logged as such.

jdef commented 6 years ago

I'm pretty sure that, at one point, very-verbose logging was enabled for mesos-dns on dc/os. I took a peek at the dcos config scripts and also observe that any "verbose" logging appears to be completely disabled. I wonder why? (Too noisy in larger clusters?)

armandgrillet commented 6 years ago

@jdef I have created https://jira.mesosphere.com/browse/DCOS_OSS-1880 to report the verbose mode issue. This PR is the result of a customer issue where having verbose logging would have been quite useful.

I do not think that this PR is dependent of DCOS_OSS-1880. If reviewers agree that an event such as new masters deserve more than a very verbose log line, it should be able to be merged.

jdef commented 5 years ago

LGTM

Just rebased. Should be merged if CI passes