[DCOS-33745] fetched cli segfault fix from dcos-commons, added a check for 401 response code - Githubissues

mesosphere / spark-build

Used to build the mesosphere/spark docker image and the DC/OS Spark package

52 stars 34 forks source link

[DCOS-33745] fetched cli segfault fix from dcos-commons, added a check for 401 response code #505

Closed rpalaznik closed 5 years ago

rpalaznik commented 5 years ago

What changes were proposed in this pull request?

Resolves [DCOS-33745] - Unhelpful error message in CLI when not logged in (https://jira.mesosphere.com/browse/DCOS-33745)

Updated vendored dependency on dcos-commons which includes a fix for segfault on empty responses (https://jira.mesosphere.com/browse/DCOS-42966 - Kubernetes CLI can segfault)
Added a custom check for "401 Unauthorized" response, to print a more helpful error message <HTTP Method> request to <URL> was not authorized. Make sure you are logged in. instead of dcos-beta-spark: error: invalid character '<' looking for beginning of value, try --help

How were these changes tested?

Manually tested
Added a unit test for CLI change

Release Notes

[Bugfix] Improved error message in CLI when not logged into a cluster

akirillov commented 5 years ago

@rpalaznik, can you please update the PR description to be on par with other merged PRs? It is also missing the 'Release Notes' section which comes very handy when we prepare release docs.