Dcos 53865 set min dcos release version to 1.11

mesosphere / spark-build

Used to build the mesosphere/spark docker image and the DC/OS Spark package

52 stars 34 forks source link

Dcos 53865 set min dcos release version to 1.11 #521

Closed ankitcid closed 5 years ago

ankitcid commented 5 years ago

What changes were proposed in this pull request?

Changed the minDcosReleaseVersion parameter to 1.11 and postUninstallNotes parameter.

Resolves ticket ID DCOS-53865 https://jira.mesosphere.com/browse/DCOS-53865

How were these changes tested?

Built SPARK and launched it on a Cluster. It worked without any issue.

Release Notes

(Please include a short summary for release notes if applicable)

samvantran commented 5 years ago

Hey @ankitcid rather than create a new PR what I do is:

checkout an earlier commit of the branch and merge the HEAD of master into it. This gives it a clean commit history up to latest of master.
add my changes in a new commit (or cherry-pick them from a backup branch)
force-push the commits to the same branch That would clean up the messy history and update the current PR.

I'll close this PR since you opened a new one but give the above method a try next time you get stuck with rebasing issues.

ankitcid commented 5 years ago

Hi @samvantran ,Thanks for these steps. I did try similar type of approach in the dcos-commons PR ( https://github.com/mesosphere/dcos-commons/pull/3059 ), and now it has openjdk master changes and my changes. Thanks.