search

mesosphere / spark-build

Used to build the mesosphere/spark docker image and the DC/OS Spark package
52 stars 34 forks source link

[DCOS-29717] The TLS tests for the data services should use different… #546

Closed mediapills closed 5 years ago

mediapills commented 5 years ago

What changes were proposed in this pull request?

Resolves DCOS-29717: The TLS tests for the data services should use different values for service_accounts and service_account_secret

This PR merge values for service_accounts and service_account_secret during tests.

How were these changes tested?

Release Notes

mediapills commented 5 years ago

Related to #3192 (dcos-common)

akirillov commented 5 years ago

Thanks for the PR @mediapills. Can you please update the PR title so it:

porridge commented 5 years ago

I think we should just drop this PR and it will just migrate naturally during the next bump.

akirillov commented 5 years ago

@porridge, unfortunately, this repo doesn't depend on dcos-commons as on a submodule but instead has a copy of dcos-commons testing code. This change looks like a port from dcos-commons which would be nice to have if this is the case.

porridge commented 5 years ago

Right, most of our repos still have just a copy. But don't you do periodic refreshes? If you only cherry pick selected changes it might become a problem at some point..

mediapills commented 5 years ago

Thanks for the PR @mediapills. Can you please update the PR title so it:

  • follows the template (example: #543)
  • contains motivation for the change in its description

@akirillov Done, could you please verify?

akirillov commented 5 years ago

Thanks, @mediapills. LGTM 👍

@porridge, we have migration to dcos-commons submodule planned for the nearest future so cherry-picking won't be a problem anymore.