search

mesosphere / traefik-forward-auth

214 stars 46 forks source link

Depreciate repo #85

Open lvijnck opened 1 year ago

lvijnck commented 1 year ago

Hi team, Can I suggest to depreciate this? Repo is not maintained. I switched over to:

https://oauth2-proxy.github.io/oauth2-proxy/docs/configuration/oauth_provider/

(which is actively maintained and has many more configuration options).

https://github.com/lvijnck/OAuth2Proxy-Traefik-KeyCloak

Repo above shows an integration example.

lvijnck commented 1 year ago

@mhrabovcin tagging for visibility

spectrapulse commented 1 year ago

I think this is a terrible idea as when I tried to use this back in the day there's been issues when making oauth2-proxy and Traefik co-operate properly and there were also completely different ideas on how to handle certain issues from both the Traefik maintainers side as the Oauth2 Proxy side. Such as the project misusing the error middleware's to rewrite 401-403's which isn't desirable. The static approach also issues both providing solutions making setups less secure which is not desirable.

As of today this fork still functions and does not need to be replaced or updated unless there's issues with the upcoming Traefik v3. But since v3 wasn't even in the RC stage last time I checked. So there's not really much to worry about as the stable branch still functions and is still supported.

funkypenguin commented 11 months ago

Also, AFAIK, the oauth-proxy implementation wouldn't support the "auth-host" features that TFA does..

syji35 commented 2 months ago

Hello,

I see that Traefik V3 has been released. Is this project compatible with V3? Additionally, this project hasn't had updates for a long time, including GO version upgrades.

spectrapulse commented 2 months ago

Hello,

I see that Traefik V3 has been released. Is this project compatible with V3? Additionally, this project hasn't had updates for a long time, including GO version upgrades.

It might have been better to ask this in a dedicated issue but I'll try to answer it anyways. From my understanding nothing changed about the Treafik forwardAuth middleware implementation in V3 so it should still just work no matter if the project is maintained or not. Although I've not tested it because I switched to Authentik quite some time ago which is a quite more advanced and a bit heavier and complicated to run than this. So I'll just recommend trying it, and if it doesn't work just try to find an alternative.

courtland commented 1 month ago

Hello,

I see that Traefik V3 has been released. Is this project compatible with V3? Additionally, this project hasn't had updates for a long time, including GO version upgrades.

AFAIK this project is dead. It's too bad too. I recently noticed an interesting fork here: https://github.com/ItalyPaleAle/traefik-forward-auth