search

mesosphere / universe

The Mesosphere Universe package repository.
http://mesosphere.github.io/universe
Apache License 2.0
305 stars 425 forks source link

Typo in etcd health check #1543

Closed deric closed 6 years ago

deric commented 6 years ago

I'm not an etcd expert but there seems to be a typo in etcd health check:

"path": "/healthz",

@jdef James could you have a look at that?

jdef commented 6 years ago

https://github.com/mesosphere/etcd-mesos/blob/8208cfad1d876bdd73162dbc7993eb2083ffd0b5/scheduler/scheduler.go#L1040

/healthz should be a valid endpoint. is the health check not working for you?

On Fri, Nov 24, 2017 at 5:53 PM, Tomas Barton notifications@github.com wrote:

I'm not an etcd expert but there seems to be a typo in etcd health check https://github.com/mesosphere/universe/blob/version-3.x/repo/packages/E/etcd/1/marathon.json.mustache#L32 :

"path": "/healthz",

@jdef https://github.com/jdef James could you have a look at that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mesosphere/universe/issues/1543, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLJ7t_1JDHdwok4tsabShZ7T44f6pks5s50j3gaJpZM4QqOdY .

deric commented 6 years ago

Right, sorry I was looking into etcd source code instead:

https://github.com/coreos/etcd/blob/0dbcd7c1a7321f0fffa4c807d35cd5ca5ed04a00/etcdserver/api/etcdhttp/metrics.go#L51