search

mesosphere / universe

The Mesosphere Universe package repository.
http://mesosphere.github.io/universe
Apache License 2.0
304 stars 426 forks source link

Avi package docker image in resource.json isn't fully specified #445

Open jsancio opened 8 years ago

jsancio commented 8 years ago

A package's resource.json needs to fully specify the resources used. That includes PNG, HTTP resources and docker images. E.g.:

> env TMPDIR='.' python3 scripts/local-universe.py --repository repo/packages/ --out-file local_universe.zip --sudo --include=avi
Adding https://s3-us-west-2.amazonaws.com/dcos/avi-small.png at avi/images/avi-small.png to file zip.
Adding https://s3-us-west-2.amazonaws.com/dcos/avi-medium.jpg at avi/images/avi-medium.jpg to file zip.
Adding https://s3-us-west-2.amazonaws.com/dcos/avi-high.jpg at avi/images/avi-high.jpg to file zip.
Pull docker images: avinetworks/controller
Using default tag: latest
Trying to pull repository docker.io/avinetworks/controller ... not found
Tag latest not found in repository docker.io/avinetworks/controller
Pull docker images: avinetworks/se
Using default tag: latest
Trying to pull repository docker.io/avinetworks/se ... not found
Tag latest not found in repository docker.io/avinetworks/se
Saving docker images: ['avinetworks/controller', 'avinetworks/se']
Error response from daemon: could not find image: no such id: docker.io/avinetworks/controller

If the docker image doesn't include a tag docker assumes the latest tag. In this case the latest tag doesn't exists so downloading fails. Looking at marathon.json.mustache it looks like the tag is specified out of band: https://github.com/mesosphere/universe/blob/version-2.x/repo/packages/A/avi/0/marathon.json.mustache#L27.

jsancio commented 8 years ago

cc @ksivask @kensipe

ksivask commented 8 years ago

working on resolving this.