search

mesotron / morelinq

Automatically exported from code.google.com/p/morelinq
Apache License 2.0
0 stars 0 forks source link

Code review request for Split #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:

When I added the Batch operator, I thought I could implement it in terms 
of a generalized Split operator. I was wrong, but the damage was already 
done and I had implemented and factored out all the work to implement a 
Split operator for any enumerable source. However, I have doubts about its 
general usefulness and is the reason why I am putting it in a branch.

When reviewing my code changes, please focus on:

I would appreciate it if you could review and comment on "utility" and 
general application of this operator. If you find that it makes good sense 
then I can merge it back into the turnk. Otherwise the branch can just 
serve as an archive.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by azizatif on 17 Feb 2009 at 6:17

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 19 Feb 2009 at 1:00

GoogleCodeExporter commented 9 years ago 
Interesingly, similar Split implementation below except it is 
specialized/optimized 
for strings:

http://stackoverflow.com/questions/298830/split-string-containing-command-line-
parameters-into-string-in-c/298990#298990

Original comment by azizatif on 14 Apr 2009 at 11:11

GoogleCodeExporter commented 9 years ago 
Set review issue status to: Accepted

Original comment by jojo.rudolph@googlemail.com on 22 Apr 2010 at 3:08

GoogleCodeExporter commented 9 years ago 
Ok, I have found a pretty cool solution, it needs a little polishing but should 
be 
available tomorrow after I had a little sleep ;-)

Original comment by jojo.rudolph@googlemail.com on 22 Apr 2010 at 11:21

GoogleCodeExporter commented 9 years ago 
Bump!

Would be good if this can be reviewed prior to migrating[1] to Hg in the 
interest of having fewer open branches to carry forward.

[1] https://groups.google.com/forum/?fromgroups#!topic/morelinq-dev/IHE7LMH_eBU

Original comment by azizatif on 24 May 2012 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 25 May 2012 at 4:40

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 25 May 2012 at 4:40