mesqueeb / is-what

JS type check (TypeScript supported) functions like `isPlainObject() isArray()` etc. A simple & small integration.
https://mesqueeb.github.io/is-what/
MIT License
185 stars 20 forks source link

GitHub Pages site doesn't exist #51

Closed jcbhmr closed 1 year ago

jcbhmr commented 1 year ago

image

mesqueeb commented 1 year ago

: / I need to look into this!

jcbhmr commented 1 year ago

OHHH I know why. I forgot to let you know that you should disable the silly auto-default environment requirement that you have to deploy from main (which only applies to newly created environments that are named "github-pages"):

image

This is the default setting: image

It works well for things like this: image

BUT when you create a release and run the deploy-pages with a TAG as the base instead of MAIN, then it fails (and rightly so! That's what it was told to do 🤣)

So what you need to do is in https://github.com/mesqueeb/is-what/settings/environments, click on github-pages image

and then drink in the config screen: image

and then either a) remove the protection altogether or b) reconfigure it so that it allows tags. IMO the simplest is to remove the protection which is the default for all other environments. The "github-pages" environment is one of (if not the only) special environment that when created gets special defaults! All others default to absolutely zero restrictions. For instance, if you change:

https://github.com/mesqueeb/is-what/blob/27ce21e708b88414217975e3e7df9aa7e14a0469/.github/workflows/publish.yml#L25

to:

name: github-pages-hello

then it will create a new github-pages-hello environment which isn't the special name "github-pages" and therefore will default to no extra special restrictions. Works with no problem! How silly is that! 🤣 It's all because of the default special restrictions for the environment named "github-pages" 🤦‍♂️

mesqueeb commented 1 year ago

@jcbhmr cool i deleted the environment

jcbhmr commented 1 year ago

@mesqueeb It works! image