Closed jcbhmr closed 1 year ago
Hey! thanks for the PR.
Prettier is already a dev dependency + has a .prettierrc
file on root, so this means that eg. in VSCode it will just auto format with prettier on save.
I am a bit hesitant on this PR because
package.json
I have it ordered in a way I personally think it makes sense for people to come read it.dist
file differences when building, unless we add it as a step in the build script. I'd rather not have one more step in the build script though.
- I do not like the way that prettier-plugin orders the
package.json
I have it ordered in a way I personally think it makes sense for people to come read it.
That's OK. ❤️
- I think we should not apply prettier auto-formatting to dist files, because it will become way harder to track
dist
file differences when building, unless we add it as a step in the build script. I'd rather not have one more step in the build script though.
This is a problem that should be solved by keeping dist out of source! 😊 But yes, prettier should ignore dist files. In this case, that means duping .prettierignore with all the contents of .gitignore 🙄
@mesqueeb I've updated the scope of this particular PR to be just prettier-plugin-jsdoc
This PR would...