mesqueeb / is-what

JS type check (TypeScript supported) functions like `isPlainObject() isArray()` etc. A simple & small integration.
https://mesqueeb.github.io/is-what/
MIT License
185 stars 20 forks source link

Remove user-custom VS Code settings #61

Open jcbhmr opened 1 year ago

jcbhmr commented 1 year ago

This PR would...

It's generally recommended that formatting stuff like formatOnSave and other such rules go in your own custom user-specific VS Code settings. In general, I think that .vscode/settings.json is more for project-specific patches on things like file extension association, extension customization (like enabling "Deno mode" for tsc checking) or other workspace-specific things.

This also helps encourage better formatting scripts like running prettier -w . or similar to actually enforce these settings for all users even those using Neovim or JetBrains or whatever.

Also on a popularity note, .vscode/settings.json files are relatively rare, especially in comparison to prettierrc files! 37k vs 101k and that's just the js prettier ecosystem! 😱

If there's a genuine workflow improvement or reason for this file to be here, then I'd love to hear it and add that explanation to the readme! ❤️ Documentation about code workflow stuff is a good thing 👍