mesqueeb / is-what

JS type check (TypeScript supported) functions like `isPlainObject() isArray()` etc. A simple & small integration.
https://mesqueeb.github.io/is-what/
MIT License
170 stars 18 forks source link

Add check-version-bump workflow #72

Open jcbhmr opened 1 year ago

jcbhmr commented 1 year ago

fixes #40 This PR would...

mesqueeb commented 1 year ago

@jcbhmr I wonder if we should still merge this.

I came to the realisation: adding "publish": false, to the "np" configuration in package.json actually might be enough in our case.

The fact that it won't publish from my local machine means the github action now succeeds. Also made sure tests are ran again before the npm publish, just in case.

So I think that covers my automation wishes? Not sure if we need to force PR authors to bump their own package in this case. : )

What do you think?

jcbhmr commented 1 year ago

I still think warning (it doesn't block the merge) with a ❌ since you didn't bump the version is a Good Idea™. This is like a very basic version of "semantic release" workflow that doesn't incur any overhead like requiring labels on PRs like "major" and doesn't require "feat(thing): did thing"-style commit conventions. It's just a light "you should change the package.json version if you touch src/ stuff" workflow

TLDR: I think that this is still a good thing to merge because it stops silly "forgor version bump 😜" commits AND forces PR authors to consciously think "what kind of change is this?"