Remove dist folder - Githubissues

mesqueeb / is-what

JS type check (TypeScript supported) functions like `isPlainObject() isArray()` etc. A simple & small integration.

https://mesqueeb.github.io/is-what/

MIT License

170 stars 18 forks source link

Remove dist folder #76

Open jcbhmr opened 1 year ago

jcbhmr commented 1 year ago

🛑 DONT MERGE THIS UNTIL #59 is merged to main!

This PR would require node-gitignore #59 to be merged first since it's dependant on that ignore rule for the dist foldr.

This PR would...

[x] Delete the dist folder

This would simplify things going forward so that there is one and only one canonical copy of source code in the Git source tree.

jcbhmr commented 1 year ago

If you still want a preview of "what will the JS be?" then you can add a preview-pack.yml or similar that runs npm pack and uploads the .tar.gz as an artifact.

IMO I don't think this is needed though since TS corresponds 1:1 with JavaScript in all cases. It's designed to. The only thing that changes is types get stripped out into a .d.ts file. ...That is if you use --target ESNext 😉 -- if you use --target ES5, it'll behave the same just with some polyfill magic.