mesqueeb / is-what

JS type check (TypeScript supported) functions like `isPlainObject() isArray()` etc. A simple & small integration.
https://mesqueeb.github.io/is-what/
MIT License
185 stars 20 forks source link

Remove prettier config #77

Closed jcbhmr closed 6 months ago

jcbhmr commented 1 year ago

Going based on this sentiment:

So I just chose, there's nothing you can't do with named exports, so why not only use named exports. It's all about reducing options and streamlining, unifying, calming the mind. ;) https://github.com/mesqueeb/is-what/issues/60#issuecomment-1579424402

Reducing the amount of customization seems like a good idea. Prettier themselves even recommend against modifying the config! 😊

By far the biggest reason for adopting Prettier is to stop all the ongoing debates over styles. https://prettier.io/docs/en/option-philosophy.html

Sidenote: Prettier auto-includes any prettier-plugin-* packages, so you don't need the plugins: [] option at all

jcbhmr commented 1 year ago

IMO the default options are pretty universal. You never have to think about it again. No configuring, just npx prettier -w . and you're done. I really wish they respected the .gitignore so I didn't have to do --ignore-path .gitignore though to avoid formatting dist 😭

jcbhmr commented 1 year ago

In the future, @mesqueeb you might want to consider adopting a widespread eslint config preset like:

Or make your own! 🥳

jcbhmr commented 1 year ago

Sidenote: prettier just released Prettier v3! https://prettier.io/blog/2023/07/05/3.0.0.html

mesqueeb commented 6 months ago

will close this one in favour of https://github.com/mesqueeb/is-what/pull/87/commits/bb6c47e97ec7081695ea9f243228c945b1238d1f

Not ready yet to get rid of prettier config sorry 😅 life's too short to look at semicolons.

Looked into a couple of eslint tools / plugins, decided to go with eslint-plugin-unicorn I bundled everything at @cycraft/eslint