search

mesqueeb / vuex-easy-firestore

Easy coupling of firestore and a vuex module. 2-way sync with 0 boilerplate!
https://mesqueeb.github.io/vuex-easy-firestore
MIT License
234 stars 28 forks source link

OpenDBChannel fix #278

Closed louisameline closed 4 years ago

louisameline commented 4 years ago

Fixes a variety of issues in openDBChannel. This is a minor breaking change, as errors from onSnapshot were previously silenced, and you now have to catch them on the streaming promise.

louisameline commented 4 years ago

Actually no, there are no breaking changes here: yes there will be an error logged that didn't exist before, but it won't stop any flow of execution that used to work, so actually this doesn't change anything for previous users.

louisameline commented 4 years ago

I read this issue: https://github.com/mesqueeb/vuex-easy-firestore/issues/240 And it would make sense to return the unsubscribe function to the resolved promise as well. I'll make that change shortly.