search

mesqueeb / vuex-easy-firestore

Easy coupling of firestore and a vuex module. 2-way sync with 0 boilerplate!
https://mesqueeb.github.io/vuex-easy-firestore
MIT License
234 stars 28 forks source link

after every patch serverChange gets fired #312

Closed mesqueeb closed 4 years ago

mesqueeb commented 4 years ago

see #300

mesqueeb commented 4 years ago

@trevorgeise I will do some troubleshooting tomorrow and hope to push a fix (or your fix) soon.

@louisameline let me know if you have any thoughts on this fix Trevor suggested.

louisameline commented 4 years ago

I've read Trevor's code and it seems logical. I haven't actually run it or tested it though. Creating the dot notation array only to reparse it afterwards does not seem very efficient but it's better than nothing, and probably still more efficient than creating a whole new object. It could probably work for v1 but I'd say there's some deeper refactoring to do for next version.

mesqueeb commented 4 years ago

@trevorgeise fixed in 1.35.7 thanks again!