Closed louisameline closed 3 years ago
Right, I overlooked the compatibility code block, but this line can actually also go away when we get rid of it, so it could be moved inside of it.
This has to get merged, please don't let it rot until it has annoying conflicts again.
Doing some final tests related to multiple tabs with a user today!
I think, without that small change, it would break if someone does:
In this case
null
is actually passed as theparameters
so it throws an erroron the next line.
You're probably thinking "why in the world would someone pass
null
, which I thought so myself, but it's the official Vuex docs that actually have that pattern show in their examples...So yeah, we gotta think that some ppl will also pass
null
where we expect only either an object orundefined
.