mesqueeb / vuex-easy-firestore

Easy coupling of firestore and a vuex module. 2-way sync with 0 boilerplate!
https://mesqueeb.github.io/vuex-easy-firestore
MIT License
233 stars 28 forks source link

feat: upgrade firebase to v9.0 and vue3 #376

Open adrianjost opened 2 years ago

adrianjost commented 2 years ago

πŸ’¬ About

I've updated the dependencies of one of my hobby projects to use Vue3 and the latest firebase SDK (v9, not in compat mode). To keep it running, I patched this package until it worked for my specific use case. ~I have not updated any test cases nor am I sure I've covered all cases. But in my limited use case everything worked as expected.~

Maybe this can be a starting point for someone else to update this library to the latest dependency versions. Unfortunately, I don't have time for that.

πŸ” What has changed?

πŸ’₯ Breaking Changes

🚫 What's missing

πŸ‘¨β€πŸ’» How can I use that?

Currently, you could use: npm i --save vuex-easy-firestore@github:adrianjost/vuex-easy-firestore#sdk-9 to test the patch from this PR in your repo. But I don't recommend doing this except for testing compatibility and adding further fixes.

adrianjost commented 2 years ago
adrianjost commented 2 years ago

A little update: I got all tests working βœ…

adrianjost commented 2 years ago

And now I even got some time to update the docs as well. πŸŽ‰

mesqueeb commented 2 years ago

@adrianjost really amazing job! let's get this released. I contacted you via your website.

adrianjost commented 2 years ago

Feel free to merge and release this whenever you want. From my side the code should be ready for it.

I'm just not 100% sure, if it should be released as 2.0.0 (because the new dependency versions are incompatible with the old ones) or it's okay the way it is. Semver isn't that clear to me in this case: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

dassmilytier commented 1 year ago

would love to see this feature finally merged. I was super happy to find this library as this is exactly what I was planning to implement for my project. Unfortunately I got emidiate disappointment when the library failed to load due to broken imports. Please continue your great work and merge this feature.