Resolve insert/patch promises after actual execution at Firestore

mesqueeb commented 6 years ago

Improve the way that inserting/patching gives feedback to the Dev to allow the Dev to easily implement things like loading spinners / animated svgs etc.

_{After about two years of open source, I finally got accepted for Github Sponsors!}

💜 github.com/sponsors/mesqueeb 💜

A little about me:

I love open-source
6 months ago I got a son, and am trying to be an awesome father 😅
I'm doing freelance work here and there as my main job

If anyone was helped with vuex-easy-firestore, I'd greatly appreciate any support!

BTW, donations get's paid DOUBLE by GitHub! (they're alchemists... 🦾)

Going forward 👨🏼‍💻

I got great plans for the future of vuex-easy-firestore going above and beyond!! Look forward to it!!
On to many more years of open-sourcing! 🎉

gerrykeys commented 5 years ago

That would be great!

mesqueeb commented 5 years ago

I was surprised to see 5 thumbs up, 3 hurrays and 3 hearts.

I'm actually thinking of not bothering with this because of this reason:

With the way that Firestore works it immediately (usually under 1 sec) resolves any update or set api call and treats it as "completed" even if the server change is still pending.
even when your device is offline / has slow internet, the firebase JS SDK has under-the-hood optimisation to just push any changes to the server whenever a connection is re-established.
this results in a situation where it does not matter for the consumer of your app to know if your changes are actually written on the server or not it will resolve itself whatever happens.

This is radically different from old PHP websites I used to build, and I believe because of this implementing a "loading spinner" for inserting/patching shouldn't be done.

I'll keep the issue open for visibility and am open to listen to any arguments!

_{Vuex Easy Firestore was made with ♥ by Luca Ban.
If this library helped you in any way you can support me by buying me a cup of coffee.}

louisameline commented 4 years ago

This will be just like Firestore: in 2-way sync, you can expect the store to be updated immediately. In the future, in 1-way sync OR when you want to be sure the update is effective at Firestore, you can wait for the promise returned by the action to settle. @mesqueeb you can remove the won't fix label ;)

mesqueeb / vuex-easy-firestore